Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackathon Pyrobench: Test previous optimization #498 #557

Draft
wants to merge 1 commit into
base: 20240807_retest-perf-a-before
Choose a base branch
from
Draft

Hackathon Pyrobench: Test previous optimization #498 #557

wants to merge 1 commit into from

Conversation

simonswine
Copy link
Contributor

This is used for #hackathon-2024-08-pyroscope-benchmarkers

It is meant to show the improvement of #498 using pyrobench.

@pracucci @simonswine
Optimize inflightInstanceTracker (#498)
1c36612 
* Optimize inflightInstanceTracker

Signed-off-by: Marco Pracucci <[email protected]>

* Update CHANGELOG

Signed-off-by: Marco Pracucci <[email protected]>

* Use range to iterate

Signed-off-by: Marco Pracucci <[email protected]>

---------

Signed-off-by: Marco Pracucci <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Benchmark Report

Finished

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Benchmark Report

Finished

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Benchmark Report

In progress

3ba30e2 -> dc02795 (compare)

github.com/grafana/dskit/ring.BenchmarkPartitionInstanceRing_GetReplicationSetsForOperation
Resource Base Head Diff %
alloc_space 15 GiB 16 GiB 3.84 %
alloc_objects 142.754969 M 144.374964 M 1.13 %
cpu 39.07 s 39.44 s 0.94 %
github.com/grafana/dskit/ring.BenchmarkPartitionRing_ActivePartitionForKey
Resource Base Head Diff %
cpu 44.17 s 44.14 s -0.06 %
alloc_space 4.4 GiB 4.4 GiB 1.19 %
alloc_objects 155.728636 M 154.663755 M -0.68 %
github.com/grafana/dskit/ring.BenchmarkPartitionRingGetTokenRangesForPartition
Resource Base Head Diff %
cpu 170.99 s 171.4 s 0.23 %
alloc_space 48 GiB 47 GiB -1.26 %
alloc_objects 320.881699 M 317.171942 M -1.15 %
github.com/grafana/dskit/ring.BenchmarkActivePartitionBatchRing_Get
Resource Base Head Diff %
alloc_objects 19.154558 M 18.516771 M -3.32 %
cpu 36.94 s 37.05 s 0.29 %
alloc_space 542 MiB 554 MiB 2.21 %
github.com/grafana/dskit/ring.BenchmarkReplicationSetZoneCount
Resource Base Head Diff %
cpu 274.33 s 276.12 s 0.65 %
alloc_space 57 GiB 57 GiB -0.01 %
alloc_objects 2.459015 G 2.455529 G -0.14 %
github.com/grafana/dskit/ring.BenchmarkInflightInstanceTracker
Resource Base Head Diff %
cpu 30.79 s 28.43 s -7.66 %
alloc_space 7.2 GiB 4.1 GiB -42.86 %
alloc_objects 84.131804 M 58.89523 M -29.99 %
github.com/grafana/dskit/ring.BenchmarkBatch10x100
Resource Base Head Diff %
cpu 46.83 s 46.81 s -0.04 %
alloc_space 5.8 GiB 5.7 GiB -1.67 %
alloc_objects 22.055678 M 21.289272 M -3.47 %
github.com/grafana/dskit/ring.BenchmarkBatch100x100
Resource Base Head Diff %
cpu 94.89 s 95.23 s 0.35 %
alloc_space 13 GiB 13 GiB -0.20 %
alloc_objects 107.040322 M 106.804845 M -0.21 %
github.com/grafana/dskit/ring.BenchmarkBatch100x1000
Resource Base Head Diff %
cpu 32.91 s 32.82 s -0.27 %
alloc_space 4.2 GiB 4.3 GiB 1.79 %
alloc_objects 13.421436 M 13.637513 M 1.60 %
github.com/grafana/dskit/ring.BenchmarkUpdateRingState
Resource Base Head Diff %
cpu 547.55 s 571.08 s 4.29 %
alloc_space 184 GiB 190 GiB 3.18 %
alloc_objects 152.622212 M 151.824947 M -0.52 %
github.com/grafana/dskit/ring.BenchmarkRing_ShuffleShard
Resource Base Head Diff %
cpu 1.33908 ks 1.34667 ks 0.56 %
alloc_space 339 GiB 340 GiB 0.31 %
alloc_objects 259.345814 M 257.967526 M -0.53 %
github.com/grafana/dskit/ring.BenchmarkRing_ShuffleShardCached
Resource Base Head Diff %
cpu 661.19 s 661.56 s 0.05 %
alloc_space 133 GiB 133 GiB 0.05 %
alloc_objects 47.889286 M 47.900762 M 0.02 %
github.com/grafana/dskit/ring.BenchmarkRing_ShuffleShard_512Tokens
Resource Base Head Diff %
cpu 25.62 s 25.42 s -0.78 %
alloc_space 6.3 GiB 6.3 GiB 0.32 %
alloc_objects 6.222382 M 5.484776 M -11.85 %
github.com/grafana/dskit/ring.BenchmarkRing_ShuffleShard_LargeShardSize
Resource Base Head Diff %
cpu 32.42 s 32.28 s -0.43 %
alloc_space 7.0 GiB 7.0 GiB 0.16 %
alloc_objects 2.212208 M 1.877103 M -15.14 %
github.com/grafana/dskit/ring.BenchmarkRing_Get
Resource Base Head Diff %
cpu 63 s 62.82 s -0.28 %
alloc_space 71 MiB 66 MiB -7.26 %
alloc_objects 20.926 k 45.416 k 117.03 %
github.com/grafana/dskit/ring.BenchmarkSpreadMinimizingTokenGenerator_GenerateTokens
Resource Base Head Diff %
cpu 12.48 s 12.16 s -2.56 %
alloc_space 1.3 GiB 1.3 GiB -2.37 %
alloc_objects 48.007141 M 47.276887 M -1.52 %
github.com/grafana/dskit/ring.BenchmarkGetTokenRangesForInstance
Resource Base Head Diff %
github.com/grafana/dskit/ring.BenchmarkCompareCountingOfSeriesViaRingAndTokenRanges
Resource Base Head Diff %
github.com/grafana/dskit/ring.BenchmarkSearchToken
Resource Base Head Diff %
github.com/grafana/dskit/ring/bench.BenchmarkMemberlistReceiveWithRingDesc
Resource Base Head Diff %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonswine @pracucci